[webkit-reviews] review requested: [Bug 5776] REGRESSION: YAHOO: Generated numbers of ordered lists (OL) are not calculated right : [Attachment 6214] Proposed patch 4

[bugzilla-request-daemon at opendarwin.org]

Andrew Wellington <proton at wiretapped.net> has asked  for review:
Bug 5776: REGRESSION: YAHOO: Generated numbers of ordered lists (OL) are not
calculated right
http://bugzilla.opendarwin.org/show_bug.cgi?id=5776

Attachment 6214: Proposed patch 4
http://bugzilla.opendarwin.org/attachment.cgi?id=6214&action=edit

------- Additional Comments from Andrew Wellington <proton at wiretapped.net>
- Check that list that start value is fetched from is an <ol> list
- New test case ol-display-types.html that covers messing with the list using
CSS
- Modified behaviours to check against isListElement() instead of tag names.
This is workable now that this code is in the render tree.
- Now match Firefox's display (seems to match common sense) for items with
display: list-item or <li> tags with a different display type. IE's behaviour
doesn't seem to make any sense, and it's unlikely that there's significant
reliance on IE's seemingly broken method of numbering when messing with display
types in CSS.
- previousListItemElement() now takes an optional parent list if the calling
function knows it. calcListValue() uses this.
- change logic in setStyle() to have a marker in all cases except error images.
Previous code didn't have one when display: none, this could potentially cause
crashes.
- did all of the cleanups because they're a good idea :)