[webkit-reviews] review requested: [Bug 6983] Clean up testkjs, add new "run" functionality : [Attachment 6212] patch2

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Feb 2 17:06:17 PST 2006

Geoffrey Garen <ggaren at apple.com> has asked  for review:
Bug 6983: Clean up testkjs, add new "run" functionality

Attachment 6212: patch2

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I thought ascii() was "debug only" for DOMString, not UString. (I ask because
the bindings code uses it -- maybe it shouldn't?) cstring() is not an option
because it just calls ascii(), so I've gone with UTF8String().

I prefer "run" to "load" because it conveys the fact that you're actually going
to execute the script.

Fixed GlobalImp on the stack.

More information about the webkit-reviews mailing list