[webkit-reviews] review denied: [Bug 5146] max-height/max-width not resizing images with correct aspect ratio : [Attachment 6089] patch 2

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Feb 1 21:26:45 PST 2006


Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 5146: max-height/max-width not resizing images with correct aspect ratio
http://bugzilla.opendarwin.org/show_bug.cgi?id=5146

Attachment 6089: patch 2
http://bugzilla.opendarwin.org/attachment.cgi?id=6089&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I went to land this patch, and discovered that the test case
maxwidth-percent.html fails with the patch.

I debugged a bit and found that when computing the width,
RenderBox::calcReplacedWidthUsing(MaxWidth) calls containingBlockWidth() and
gets 0, so it returns intrinsicWidth, 100, instead of 50% of the containing
block's width. The reason containingBlockWidth() gets 0 is that usesLineWidth()
returns true.

It's possible this fix worked fine in the KDE tree but we need more work to get
it to do the right thing.



More information about the webkit-reviews mailing list