[webkit-reviews] review denied: [Bug 6821] Fix for 5983 will not always update hover correctly. : [Attachment 6197] Updated patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Wed Feb 1 20:45:26 PST 2006


Darin Adler <darin at apple.com> has denied opendarwin.org at mitzpettel.com's
request for review:
Bug 6821: Fix for 5983 will not always update hover correctly.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6821

Attachment 6197: Updated patch
http://bugzilla.opendarwin.org/attachment.cgi?id=6197&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Patch will have to be revised, since there's no such thing as startTimer any
more; I just redid timers.

Also, for that text node stuff, maybe we need to make NodeImpl::ancestorElement
public so we could say something more like node->ancestorElement() !=
m_activeNode -- I'm thinking that if it's never a text node it should be
m_activeElement rather than m_activeNode, not that we have to fix that to fix
this bug.

Doing review- because of the timer thing. Sorry about that.



More information about the webkit-reviews mailing list