[webkit-reviews] review denied: [Bug 12013] REGRESSION: <pattern> in objectBoundingBox mode are broken. : [Attachment 12099] Updated patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Dec 29 09:48:45 PST 2006

Eric Seidel <macdome at opendarwin.org> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 12013: REGRESSION: <pattern> in objectBoundingBox mode are broken.

Attachment 12099: Updated patch

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Ok, the code looks good.

1.  Need to remove the 1x1 pruning in SVGRenderContainer
2. Need to file a bug about the /100 issue
3.  You said you were going to fix gradients to be lazy
4. Need to add some test cases, including one for failed mask allocations.  You
said you created a bunch of crazy tests, but I don't see them here.  The test
cases are almost more important than the code changes as once we have the
tests, we'll never break them.
+	 IntRect textBoundary =
+	 targetRect =
seems kinda hacky.  I'm surprise there isn't a method to get you what you want

Otherwise looks great!

More information about the webkit-reviews mailing list