[webkit-reviews] review requested: [Bug 11849] REGRESSION (r18182): Google Calendar is broken (a regular expression containing a null character is not parsed correctly) : [Attachment 12106] Change pcre_compile to take the pattern's length and work with patterns containing null characters

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Fri Dec 29 08:37:22 PST 2006


mitz at webkit.org has asked  for review:
Bug 11849: REGRESSION (r18182): Google Calendar is broken (a regular expression
containing a null character is not parsed correctly)
http://bugs.webkit.org/show_bug.cgi?id=11849

Attachment 12106: Change pcre_compile to take the pattern's length and work
with patterns containing null characters
http://bugs.webkit.org/attachment.cgi?id=12106&action=edit

------- Additional Comments from mitz at webkit.org
No layout test regressions, no JSC test regressions, two JSC tests fixed, no
PCRE test regressions (when applying an equivalent patch to pcre-6.1).

I would really appreciate it if someone who knows how to do it measured the
performance impact of this patch and of the alternative approach (attachment
12081).



More information about the webkit-reviews mailing list