[webkit-reviews] review granted: [Bug 11625] Investigate possibility to share code between HTMLStyleElement and SVGStyleElement : [Attachment 11571] AtomicString improvements

[bugzilla-request-daemon at macosforge.org]

Darin Adler <darin at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 11625: Investigate possibility to share code between HTMLStyleElement and
SVGStyleElement
http://bugs.webkit.org/show_bug.cgi?id=11625

Attachment 11571: AtomicString improvements
http://bugs.webkit.org/attachment.cgi?id=11571&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
+	     Element *e = static_cast<Element *>(n);

Should move the * next to Element.

+#include "Node.h"
+#include "Document.h"

No need to include both Document and Node, since Document is a Node.

+    String _type = type();

It's best to not use leading underscores in identifiers, since those are
reserved for the compiler and operating system.

+class MappedAttribute;

This is a forward declaration for a class not used in the file; please leave it
out.

+class StyleElement
+{

Where did the following code go?

-    if (attr->name() == typeAttr)
-	 m_type = attr->value().domString().lower();

Again, please don't use underscores:

+    static const AtomicString _default("text/ecmascript");
+    static const AtomicString _xmlspace("xml:space");
+    static const AtomicString _default("all");

r=me