[webkit-reviews] review denied: [Bug 11053] XMLHttpRequest should be an EventTarget : [Attachment 11633] proposed patch

bugzilla-request-daemon at macosforge.org bugzilla-request-daemon at macosforge.org
Thu Dec 7 15:45:11 PST 2006

Geoffrey Garen <ggaren at apple.com> has denied Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 11053: XMLHttpRequest should be an EventTarget

Attachment 11633: proposed patch

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
+ HashMap<AtomicStringImpl*, Vector<RefPtr<EventListener> > >

Pleae use a typedef for this monstrosity.

There are subtle differences between the EventTarget implementation here and
the one in EventTargetNode. It would be nice to have a common base class that
both EventTargetNode and XMLHttpRequest could inherit from ("EventTarget?").
EventTargetNode would have to supplement its behavior -- to support listeners
on disconnected nodes, for example -- but the base functionality of tracking
event handlers would be identical. This would prevent bugs due to subtle
differences in implementation from creeping in, and improve readability. What
do you think?

More information about the webkit-reviews mailing list