[webkit-reviews] review denied: [Bug 7476] WebKit does not handle invalid MIME types for SVG : [Attachment 10004] nicer fix & frame.cpp cleanup (ignoring whitespace)

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Darin Adler <darin at apple.com>'s
request for review:
Bug 7476: WebKit does not handle invalid MIME types for SVG
http://bugzilla.opendarwin.org/show_bug.cgi?id=7476

Attachment 10004: nicer fix & frame.cpp cleanup (ignoring whitespace)
http://bugzilla.opendarwin.org/attachment.cgi?id=10004&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks generally fine, but this won't compile:

+    return (mimeType == "image/svg+xml");
+	  || mimeType == "image/svg-xml" // invalid, Adobe SVG Viewer
compatibility
+	  || mimeType == "image/xml+svg"); // invalid, Adobe SVG Viewer
compatibility

Also, we should have some tests of these MIME types -- we have http tests that
can test this sort of thing.

-	     d->m_decoder->setEncodingName(d->m_encoding.latin1(),
-		 d->m_haveEncoding ? Decoder::UserChosenEncoding :
Decoder::EncodingFromHTTPHeader);
+	     d->m_decoder->setEncodingName(d->m_encoding.latin1(),
d->m_haveEncoding ? Decoder::UserChosenEncoding :
Decoder::EncodingFromHTTPHeader);

The above does not look like an improvement. The old formatting looks better.