[webkit-reviews] review requested: [Bug 10247] Unable to build webkit without SVG/XPATH : [Attachment 9902] patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Aug 6 14:13:41 PDT 2006

Graham Dennis <Graham.Dennis at gmail.com> has asked  for review:
Bug 10247: Unable to build webkit without SVG/XPATH

Attachment 9902: patch

------- Additional Comments from Graham Dennis <Graham.Dennis at gmail.com>
I'm not sure that this is the correct fix, but...
My understanding is that before SVG_SUPPORT and XPATH_SUPPORT were changed to
be set by FEATURE_DEFINES, they were set to either 1 or 0. Now it seems that it
is either defined or not. So my fix is to change every #if SVG_SUPPORT or #if
XPATH_SUPPORT to #ifdef SVG_SUPPORT or #ifdef XPATH_SUPPORT respectively.

More information about the webkit-reviews mailing list