[webkit-reviews] review denied: [Bug 10274] Move to use PLATFORM() macros. : [Attachment 9897] first patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Aug 6 11:03:50 PDT 2006

Geoffrey Garen <ggaren at apple.com> has denied Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 10274: Move to use PLATFORM() macros.

Attachment 9897: first patch

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
JSStringRef.h is a public header, so it can't include WTF stuff. That probably
means we shouldn't use WTF in JSStringRef.cpp, either, because we want the
header and implementation to use matching macros.

PLATFORM(DARWIN) is probably the wrong test for CF-related code in JSStringRef*
and testapi.c, since CF isn't tied to Darwin. A CF-related test is probably

PLATFORM(DARWIN) also seems wrong in kjs_*, since it's really about ObjC
support more than anything. PLATFORM(MAC), maybe?

Otherwise, this patch looks good.

More information about the webkit-reviews mailing list