[webkit-reviews] review granted: [Bug 8420] iExploder(#12): Assertion failure in RenderContainer::removeChildNode : [Attachment 7743] Don't allow splitting button's inner container

[bugzilla-request-daemon at opendarwin.org]

Eric Seidel <macdome at opendarwin.org> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 8420: iExploder(#12): Assertion failure in RenderContainer::removeChildNode
http://bugzilla.opendarwin.org/show_bug.cgi?id=8420

Attachment 7743: Don't allow splitting button's inner container
http://bugzilla.opendarwin.org/attachment.cgi?id=7743&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
The patch looks totally sane.  The layout test could possibly have been simpler
(using JS to test the number of children for instance).  My only concern is
performance, I have no idea how hot this code is.  I'm going to r+ and leave
hyatt or darin to complain if I was wrong.