[webkit-reviews] review requested: [Bug 8408] Paint the highlight behind selected list markers : [Attachment 7744] Revised patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Apr 16 08:15:13 PDT 2006

opendarwin.org at mitzpettel.com has asked  for review:
Bug 8408: Paint the highlight behind selected list markers

Attachment 7744: Revised patch

------- Additional Comments from opendarwin.org at mitzpettel.com
(In reply to comment #2)
> Why isn't there a check of selectionState() inside the "isErrorImage" code
> path?

My mistake, corrected in this version.

> The 153 alpha thing from RenderReplaced is really ugly. I'd like it to be
> something more like this to make the 60% clear:
>     const int selectionColorImageOverlayAlpha = 60 * 255 / 100;
> If it was in a header file it could be shared with RenderReplaced.

Added in RenderObject.h.

> Is it really correct to set the selection state of the item to match the
> of the list marker?

Yet another mistake. In this version I replaced the list item with the
containing block both in setSelecitonState() and in selectionRect().

More information about the webkit-reviews mailing list