[webkit-reviews] review requested: [Bug 8389] support for Cocoa bindings - binding an NSTreeController to the WebView's DOM : [Attachment 7720] new patch for review

[bugzilla-request-daemon at opendarwin.org]

James G. Speth <speth at end.com> has asked  for review:
Bug 8389: support for Cocoa bindings - binding an NSTreeController to the
WebView's DOM
http://bugzilla.opendarwin.org/show_bug.cgi?id=8389

Attachment 7720: new patch for review
http://bugzilla.opendarwin.org/attachment.cgi?id=7720&action=edit

------- Additional Comments from James G. Speth <speth at end.com>
i snuck one new thing in here which is that WebScriptObject valueForKey: now
calls super if the javascript returns undefined.  this is actually what i
really wanted with that WebUndefined description business, but i was wimping
out for some reason.

if super valueForKey: fails it will call valueForUndefinedKey, which is
important because it causes the right behavior to happen with bindings using
the "Raises for Not Applicable Keys" flag and the Not Applicable Placeholder
setting.

this lets you set an empty string as the placeholder, and get rid of all the
"undefined"s in the outline view for nodes that don't have innerHTML (for
instance).