[webkit-reviews] review denied: [Bug 8353] CSS3: Implement background-size property : [Attachment 7703] Includes layout tests

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Fri Apr 14 17:25:13 PDT 2006

Dave Hyatt <hyatt at apple.com> has denied Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 8353: CSS3: Implement background-size property

Attachment 7703: Includes layout tests

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
(1) Let's just revert the image methods back to their original names.

(2) The norepeat argument doesn't really work.	The higher level code can just
call draw directly with the right dstRect.  You should not have to deal with
norepeat explicitly in the tiling method.

(3) For both Cairo and Mac, the case where the single tile is bigger than the
destination rect is wrong.  It's basically backwards.  You should always be
drawing into the original dstRect, and then you have to go from the scaled tile
back to the original unscaled portion of the image.  Then when the draw happens
the scale will occur in the right direction.

More information about the webkit-reviews mailing list