[webkit-reviews] review granted: [Bug 5176] run-webkit-tests --guard crashes on TOT : [Attachment 4097] updated patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Sep 29 14:54:37 PDT 2005

Darin Adler <darin at apple.com> has granted opendarwin.org at mitzpettel.com's
request for review:
Bug 5176: run-webkit-tests --guard crashes on TOT

Attachment 4097: updated patch

------- Additional Comments from Darin Adler <darin at apple.com>
I think that it might be better to have a GETCHARINC macro that took an end
pointer and returned a special value rather than repeating this logic in
multiple places. That having been said, the patch looks fine except for the
parenthesis issue I mentioned in my earlier comment. r=me

More information about the webkit-reviews mailing list