[webkit-reviews] review granted: [Bug 5176] run-webkit-tests --guard crashes on TOT : [Attachment 4093] suggested patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Sep 29 14:52:21 PDT 2005


Darin Adler <darin at apple.com> has granted opendarwin.org at mitzpettel.com's
request for review:
Bug 5176: run-webkit-tests --guard crashes on TOT
http://bugzilla.opendarwin.org/show_bug.cgi?id=5176

Attachment 4093: suggested patch
http://bugzilla.opendarwin.org/attachment.cgi?id=4093&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
The line:

	  if IS_LEADING_SURROGATE(dc)

should really be

	  if (IS_LEADING_SURROGATE(dc))

because it's a bit yucky to depend on the parentheses inside the macro.
Otherwise, this looks great. r=me



More information about the webkit-reviews mailing list