[webkit-reviews] review requested: [Bug 5027] Decoder doesn't auto-detect XML encoded as UTF-16 if BOM is not present : [Attachment 3925] proposed patch

[bugzilla-request-daemon at opendarwin.org]

Eric Seidel <macdome at opendarwin.org> has asked Darin Adler <darin at apple.com>
for review:
Bug 5027: Decoder doesn't auto-detect XML encoded as UTF-16 if BOM is not
present
http://bugzilla.opendarwin.org/show_bug.cgi?id=5027

Attachment 3925: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=3925&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
Well, the code looks fine, as in it does what it says it does.	I'm not sure
what the policy on autodetection is.  The previous if block before this one
finds <?xml and searches for an encoding listed there.	This one finds	< ? x m
l  says, oh those must be 2 byte characters, and assumes unicode 16. I'm not
sure if that's a good thing or not, and thus will leave this one up to Darin to
decide.