[webkit-reviews] review denied: [Bug 3418] unicode characters not preserved after a xslt transformation : [Attachment 3928] proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Sep 17 15:03:54 PDT 2005


Eric Seidel <macdome at opendarwin.org> has denied Alexey Proskuryakov
<ap at nypop.com>'s request for review:
Bug 3418: unicode characters not preserved after a xslt transformation
http://bugzilla.opendarwin.org/show_bug.cgi?id=3418

Attachment 3928: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=3928&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
The patch looks fine.  I'm not sure I fully understand the use of Decoder (I'm
not familiar with the class).  Regardless, before we can land this we will
require additional layout-tests to validate the changes.  Marking review:-
until the layout tests are attached (then you can remark this patch as ?).



More information about the webkit-reviews mailing list