[webkit-reviews] review denied: [Bug 5301] webcore+svg build fails with gcc3.3 : [Attachment 4257] Proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Oct 8 12:42:16 PDT 2005

Eric Seidel <macdome at opendarwin.org> has denied Julien Palmas
<julien.palmas at mac.com>'s request for review:
Bug 5301: webcore+svg build fails with gcc3.3

Attachment 4257: Proposed patch

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
The first change doesn't need to be in an #if block, since adding the forward
defnitions there probably should have been done in the first place (and
certainly doesn't hurt gcc 4.0).

For the second change you should instead put the #define id ID_HACK block in
the .mm file which is actually including this NodeImpl.h (likely through a long
chain of other includes).  See how this is done in DrawDocument.mm.  You won't
need to put them inside #if __GNUC__ <4 blocks then.

Please correct those two and post another patch.  Thanks!

More information about the webkit-reviews mailing list