[webkit-reviews] review denied: [Bug 4680] WebHTMLView (WebNSTextInputSupport) - attributedSubstringFromRange "not yet implemented" : [Attachment 4208] Updated patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sat Oct 8 11:17:02 PDT 2005

Darin Adler <darin at apple.com> has denied Evan Gross <evan at rainmakerinc.com>'s
request for review:
Bug 4680: WebHTMLView (WebNSTextInputSupport) - attributedSubstringFromRange
"not yet implemented"

Attachment 4208: Updated patch

------- Additional Comments from Darin Adler <darin at apple.com>
There's a fundamental problem here because _attributeStringFromDOMRange: uses
an entirely different code path than our usual conversion to a string, and
there's no way to guarantee they are in sync.

I don't like the strategy here; I think instead we need to create a new
conversion to attributed string that *is* based on the WebCore text machinery
(rather than relying no the entirely-outside-WebKit one from AppKit we are
currently using) for this call.

I'm sorry; I know that's a bigger undertaking than this patch.

More information about the webkit-reviews mailing list