[webkit-reviews] review granted: [Bug 5715] document.charset,
document.defaultCharset, and document.characterSet are not supported :
[Attachment 4821] proposed patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sun Nov 27 18:35:24 PST 2005
Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at nypop.com>'s
request for review:
Bug 5715: document.charset, document.defaultCharset, and document.characterSet
are not supported
http://bugzilla.opendarwin.org/show_bug.cgi?id=5715
Attachment 4821: proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=4821&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
I think that the Charset setting code should use UTF8String() instead of
cstring(). The patch looks otherwise perfect, so I'm going to mark it review+
anyway, since cstring() seems OK.
More information about the webkit-reviews
mailing list