[webkit-reviews] review denied: [Bug 4726] Drop of multiple non-image file URLs only yields one item : [Attachment 4814] Proposed patch 4

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Sun Nov 27 18:33:22 PST 2005

Darin Adler <darin at apple.com> has denied Andrew Wellington
<proton at wiretapped.net>'s request for review:
Bug 4726: Drop of multiple non-image file URLs only yields one item

Attachment 4814: Proposed patch 4

------- Additional Comments from Darin Adler <darin at apple.com>
Very nice!

Two comments:

    1) I feel like an idiot. Now that I read it I see that
createFragmentFromText puts each element inside a default paragraph except for
the last line if it is empty. So the magic "BR" code in
createFragmentFromNodeList is probably not needed at all. I'm really sorry
about leading you astray about this; we should probably just take that out.

    2) createFragmentFromNodeList should take a const QPtrList<DOM::NodeImpl>&
rather than QPtrList<DOM::NodeImpl>*.

Despite my marking it review-, this patch is in great shape. Thanks for all the
hard work on this.

More information about the webkit-reviews mailing list