[webkit-reviews] review granted: [Bug 5768] pages with frames that are all "fixed" get no layout and are blank (like www.farnell.nl) : [Attachment 4736] Proposed patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Nov 22 19:55:15 PST 2005


Darin Adler <darin at apple.com> has granted opendarwin.org at mitzpettel.com's
request for review:
Bug 5768: pages with frames that are all "fixed" get no layout and are blank
(like www.farnell.nl)
http://bugzilla.opendarwin.org/show_bug.cgi?id=5768

Attachment 4736: Proposed patch
http://bugzilla.opendarwin.org/attachment.cgi?id=4736&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I was fooled by the formatting changes into thinking this was a bigger change
than it is. The substance of this change is simple, and clearly a good idea.

But can't we just move the end2: label up one line to get the same effect? I
don't see a lot of value in indenting all the code.



More information about the webkit-reviews mailing list