[webkit-reviews] review denied: [Bug 4726] Drop of multiple non-image file URLs only yields one item : [Attachment 4710] Proposed patch 2

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Tue Nov 22 19:52:35 PST 2005

Darin Adler <darin at apple.com> has denied Andrew Wellington
<proton at wiretapped.net>'s request for review:
Bug 4726: Drop of multiple non-image file URLs only yields one item

Attachment 4710: Proposed patch 2

------- Additional Comments from Darin Adler <darin at apple.com>
For multiple lines in HTML we use p elements, not br elements.

So this code needs to be more like createFragmentFromText in markup.cpp.

Each item should be in a paragraph created by createDefaultParagraphElement.
Image items could be image elements and text items could be text nodes just as
in the code here.

A clean way to do this is to put a function over on the WebCore side that takes
a list of nodes and puts each one in a separate paragraph. The code on this
side could just pass an NSArray of DOMNode objects over the bridge to get to
that side.

Having more of the code on the WebCore side is better for portability to other
platforms anyway.

Sorry to make this harder, but we really want functions like this to be
consistent with other editing code.

More information about the webkit-reviews mailing list