[webkit-reviews] review granted: [Bug 3771] GW: Update create_hash_table closer to TOT KJS : [Attachment 2712] relatively simple patch, which adds support to create_hash_table as detailed in the bug

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has granted Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 3771: GW: Update create_hash_table closer to TOT KJS
http://bugzilla.opendarwin.org/show_bug.cgi?id=3771

Attachment 2712: relatively simple patch, which adds support to
create_hash_table as detailed in the bug
http://bugzilla.opendarwin.org/attachment.cgi?id=2712&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I'd prefer to roll in the "string tables" change at the same time, myself.

I'm also not fond of comments that say "NEW", since they inevitably become
"OLD" :-)

I also don't like checking in commented-out debugging code.

And it's very strange to use this:

    ".$nameEntries."

when you one could just have said:

    $nameEntries

But these are minor quibbles -- seems fine to land this.