[webkit-reviews] review denied: [Bug 3630] Input type range rounds negative values improperly : [Attachment 2519] Patch to fix the rounding behavior

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Thu Jun 30 08:19:22 PDT 2005


Darin Adler <darin at apple.com> has denied Brian Campbell <lambda at mac.com>'s
request for review:
Bug 3630: Input type range rounds negative values improperly
http://bugzilla.opendarwin.org/show_bug.cgi?id=3630

Attachment 2519: Patch to fix the rounding behavior
http://bugzilla.opendarwin.org/attachment.cgi?id=2519&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Patch and test case both look pretty good, but we also need a layout test.

Since were converting to an int, perhaps the better call to use is lround()
rather than round()?



More information about the webkit-reviews mailing list