[webkit-reviews] Patch to fix initialization issues in the WebView subproj

Darin Adler darin at apple.com
Sun Jun 12 20:33:49 PDT 2005


On Jun 12, 2005, at 5:32 PM, Nick Zitzmann wrote:

> To be specific about what this patch does, it does the following in  
> all of the source files in WebView.subproj:
> 1. Makes it so that self is set to the result of the superclass  
> initializer
> 2. Returns nil if the superclass initializer returns nil (although  
> I agree it's unlikely this will happen, but it's good coding style  
> nonetheless)
>
> It also addresses an issue where (AFAICT) -[WebViewPrivate init]  
> was not invoking its superclass initializer at all.

Looks great. r=me. Landing it now after double-checking one more time.

     -- Darin




More information about the webkit-reviews mailing list