[webkit-reviews] Patch to fix initialization issues in the WebView subproj

Nick Zitzmann seiryu at comcast.net
Sun Jun 12 17:32:46 PDT 2005

On Jun 12, 2005, at 4:38 PM, Darin Adler wrote:

> I like the suggestion of using:
>     if (!self)
>         return nil;
> It would cause fewer changes and make it easier to merge patches  
> with this change. I'd like to see a patch that does it this way.

OK, here's patch version 1.1. I agree that this will be a lot easier  
to merge than the last patch...

To be specific about what this patch does, it does the following in  
all of the source files in WebView.subproj:
1. Makes it so that self is set to the result of the superclass  
2. Returns nil if the superclass initializer returns nil (although I  
agree it's unlikely this will happen, but it's good coding style  

It also addresses an issue where (AFAICT) -[WebViewPrivate init] was  
not invoking its superclass initializer at all.

Nick Zitzmann
S/MIME signature available upon request
-------------- next part --------------
A non-text attachment was scrubbed...
Name: WebViewInit.patch
Type: application/octet-stream
Size: 9813 bytes
Desc: not available
Url : http://lists.macosforge.org/pipermail/webkit-reviews/attachments/20050612/bf5c13d6/WebViewInit.obj
-------------- next part --------------

More information about the webkit-reviews mailing list