[webkit-reviews] Review request for Bug 3427: WebKitBuild location should not default to ~/

Darin Adler darin at apple.com
Sun Jun 12 15:24:53 PDT 2005

On Jun 12, 2005, at 2:28 PM, Stuart Morgan wrote:

> It might still be worth merging in my changes, since my version  
> will find the WebKit directory from *anywhere* (assuming you  
> haven't moved webkitdirs.pm out of its default location), whereas  
> it looks like your changes still require being somewhere inside the  
> base directory.  It's handy to be able to pop open a new terminal  
> window and just run the build script.

Yes, I like your FindDir approach better than mine. I noticed that  
after sending my mail last night, and I will be using that technique;  
merging your patch with mine in effect. In fact, I'm not event going  
to bother with the fallback stuff for cases where FindDir doesn't work.

     -- Darin

More information about the webkit-reviews mailing list