[webkit-reviews] Review request for Bug 3427: WebKitBuild location should not default to ~/

Stuart Morgan stuart.morgan at alumni.case.edu
Sun Jun 12 14:28:22 PDT 2005

On Jun 12, 2005, at 1:38 AM, Darin Adler wrote:

> On Jun 10, 2005, at 11:16 PM, Stuart Morgan wrote:
>> The attached patch fixes http://bugzilla.opendarwin.org/ 
>> show_bug.cgi?id=3427 by making webkitdirs.pm smarter about finding  
>> the directory holding the other WebKit folders, and placing the  
>> WebKitBuild folder alongside them if no custom build products  
>> directory is set.
> Oops! I didn't see this patch until just now, and I think my patch  
> makes similar changes to webkitdirs.pm!

It might still be worth merging in my changes, since my version will  
find the WebKit directory from *anywhere* (assuming you haven't moved  
webkitdirs.pm out of its default location), whereas it looks like  
your changes still require being somewhere inside the base  
directory.  It's handy to be able to pop open a new terminal window  
and just run the build script.

If you'd be interested in the patch, I'd be glad to respin against  
your update.


More information about the webkit-reviews mailing list