[webkit-reviews] build script changes for review
Darin Adler
darin at apple.com
Sun Jun 12 15:23:50 PDT 2005
On Jun 12, 2005, at 2:28 AM, Maciej Stachowiak wrote:
>> -my $lib = "${productDir}/libWebKitSystemInterface.a";
>> +my $lib = "$productDir/libWebKitSystemInterface.a";
>
> It's generally considered better perl style to have braces around a
> variable expansion in quotes, not sure why you took them out here
> and elsewhere.
I took them out because I prefer to use the same syntax for the
variables inside quotes and outside. Makes it easier when doing
searches for uses of a variable and global replacement.
I think you are overstating the case about "generally considered
better style". It's true that with the braces you can immediately
follow a variable expansion with an alphanumeric chracter, but
>> - system "mkdir", "-p", "${productDir}/usr/local/include";
>> + system "mkdir", "-p", "$productDir/usr/local/include";
>>
>
> This doesn't have much to do with your change but I would totally
> write this kind of thing as `mkdir -p "$productDir/usr/local/
> include"`.
We can discuss this another time. I think the "system with a list"
approach handles quoting better, but that might be incorrect.
> Style nitpitchs notwithstanding, r=me on the substantive changes
> (assuming you tested reasonably).
I really like Stuart Morgan's technique of using FindDir, so I'm
going to integrate that before landing the patch.
-- Darin
More information about the webkit-reviews
mailing list