[webkit-reviews] build script changes for review

Maciej Stachowiak mjs at apple.com
Sun Jun 12 02:28:35 PDT 2005

On Jun 12, 2005, at 1:30 AM, Darin Adler wrote:

> The patch at the end of this message contains a bunch of tweaks to  
> the build scripts.
> Changes include:
>     1) if you don't have a build products preference in Xcode, the  
> build directory defaults to WebKitBuild inside the same directory  
> as your WebKit sources (instead of ~/WebKitBuild)
>     2) you can set a configuration of "Development" or "Deployment"  
> and have that be a default, or pass the configuration on the  
> command line to the tools if you prefer that; the code to support  
> Xcode 2.1 is now quite a bit more streamlined (although it needs  
> testing)
>     3) The scripts work harder to find the WebKitTools directory,  
> so they can be run even from deep in a subdirectory of your WebKit  
> sources.
> Maybe I did some other stuff I forgot, but I think those are the  
> big ones.
> <BuildPatch.txt>

> -my $lib = "${productDir}/libWebKitSystemInterface.a";
> +my $lib = "$productDir/libWebKitSystemInterface.a";

It's generally considered better perl style to have braces around a  
variable expansion in quotes, not sure why you took them out here and  

> -    system "mkdir", "-p", "${productDir}/usr/local/include";
> +    system "mkdir", "-p", "$productDir/usr/local/include";

This doesn't have much to do with your change but I would totally  
write this kind of thing as `mkdir -p "$productDir/usr/local/include"`.

Style nitpitchs notwithstanding, r=me on the substantive changes  
(assuming you tested reasonably).


More information about the webkit-reviews mailing list