[webkit-reviews] Bug #3360: align="right" on a text input
aligns the input field to the right, not the text inside
Maciej Stachowiak
mjs at apple.com
Sun Jun 12 14:03:29 PDT 2005
On Jun 9, 2005, at 3:09 AM, Niels Leenheer wrote:
> I attached a patch to solve bug #3360:
> http://bugzilla.opendarwin.org/show_bug.cgi?id=3360
>
> I did not use the cvs-extract tool to generate the patch, because I
> am currently
> working on a Windows machine. This is also the reason why was not
> able to
> actually test if this patch solves the bug.
>
It looks like there has been some discussion of this in the patch
since this email. Using attach() seems closer, but I think even the
latest patch will not property handle dynamic updates to the align or
type attributes (for instance, adding align attribute to an image
after attach time seems like it will do nothing). Please fix for the
dynamic case and add a dynamic test case. I think the right way to do
this is to make an updateAlign function that is called every time
type or align gets changed, which either does addHTMLAlign, or the
equivalent to remove the align mapped attribute.
Regards,
Maciej
More information about the webkit-reviews
mailing list