[webkit-reviews] Bug #3360: align="right" on a text input aligns the input field to the right, not the text inside

[Dave Hyatt]

This patch is not correct.  I commented in the bug.

dave

On Jun 9, 2005, at 6:05 AM, Darin Adler wrote:

> On Jun 9, 2005, at 3:34 AM, Mark Rowe wrote:
>
>
>> On 9/06/2005, at 22:09 , Niels Leenheer wrote:
>>
>>
>>> I attached a patch to solve bug #3360:
>>> http://bugzilla.opendarwin.org/show_bug.cgi?id=3360
>>>
>>> I did not use the cvs-extract tool to generate the patch, because  
>>> I am currently
>>> working on a Windows machine. This is also the reason why was not  
>>> able to
>>> actually test if this patch solves the bug.
>>>
>>
>> I've tested this patch.  The patch causes the test cases at  
>> <http://bugzilla.opendarwin.org/attachment.cgi?id=2155>  and  
>> <http://www.nousoft.org/webkit-2.html> to render correctly, and  
>> does not affect the layout tests.  It could probably do with a  
>> layout test to ensure it's behaviour in the future.
>>
>
> That's great guys! Thanks!
>
> What's the purpose of the m_render check? It doesn't make sense to  
> me to ignore the ALIGN attribute if it's changed at a time the  
> element isn't attached to the render tree. I think we want a patch  
> without it.
>
> Once we deal with that, and add a layout test, I'll land the change.
>
>     -- Darin
>
> _______________________________________________
> webkit-reviews mailing list
> webkit-reviews at opendarwin.org
> http://www.opendarwin.org/mailman/listinfo/webkit-reviews
>