[webkit-reviews] Win32 compile fix: bool_object.cpp

[Darin Adler]

On Jun 10, 2005, at 3:43 PM, Justin Haygood wrote:

> bool_object.cpp
>
> Changes:
>
> On Win32, include <assert.h>. Otherwise, nothing. Might be a good  
> idea to include <assert.h> on other platforms as well

> Index: bool_object.cpp
> ===================================================================
> RCS file: /cvs/root/JavaScriptCore/kjs/bool_object.cpp,v
> retrieving revision 1.10
> diff -u -r1.10 bool_object.cpp
> --- bool_object.cpp    2005/04/29 00:22:55    1.10
> +++ bool_object.cpp    2005/06/10 22:37:54
> @@ -20,6 +20,7 @@
>   *
>   */
>
> +
>  #include "value.h"
>  #include "object.h"
>  #include "types.h"
> @@ -28,7 +29,9 @@
>  #include "bool_object.h"
>  #include "error_object.h"
>
> +#ifdef WIN32
>  #include <assert.h>
> +#endif
>
>  using namespace KJS;

I don't understand this patch. The old code always included  
<assert.h>. Your patch makes it only include <assert.h> on WIN32.

Landing this would break compilation on Mac OS X, for example.

How does this change help porting to Win32?

     -- Darin