[webkit-reviews] [PATCH] Bug #3366: Site failure: qixo.com farefinder

Nate Cook nate at natecook.com
Fri Jun 10 17:40:07 PDT 2005


On Jun 10, 2005, at 1:41p, Darin Adler wrote:

> On Jun 9, 2005, at 10:57 PM, Nate Cook wrote:
>
>> This patch adds more extensive fallback code for the Date()  
>> constructor when passed a string like:
>>         '12/25/1995 12:21:43 PST'
>>
>> Currently only the date is expected, so the year field is corrupt  
>> and causes mktime to return an invalid date. This fixes bug #3366  
>> (posted there too): http://bugzilla.opendarwin.org/show_bug.cgi? 
>> id=3366
>
> Looks pretty good. Review comments in the bug.

Thanks -- I've posted a new patch and a revised date-parse-test.html.

-Nate



More information about the webkit-reviews mailing list