[webkit-reviews] [PATCH] Bug #3366: Site failure: qixo.com farefinder

[Darin Adler]

On Jun 9, 2005, at 10:57 PM, Nate Cook wrote:

> This patch adds more extensive fallback code for the Date()  
> constructor when passed a string like:
>         '12/25/1995 12:21:43 PST'
>
> Currently only the date is expected, so the year field is corrupt  
> and causes mktime to return an invalid date. This fixes bug #3366  
> (posted there too): http://bugzilla.opendarwin.org/show_bug.cgi? 
> id=3366

Looks pretty good. Review comments in the bug.

> Question: this bug passes run-webkit-tests, but there are several  
> errors for run-mozilla-tests that seem unrelated. Is it normal for  
> JavaScriptCore to fail these tests?

I'm not sure why these tests are giving different results for people  
outside the Safari and WebKit team. We'll try to figure out what's  
going on and get it fixed.

     -- Darin