[webkit-reviews] [PATCH] JavaScriptCore with bison 2.0

[Toby Peterson]

On 07 Jun 2005, at 12.01, Darin Adler wrote:

> On Jun 7, 2005, at 1:52 AM, Toby Peterson wrote:
>
>
>> Second, bison 2.0 generates a different filename (grammar.hpp  
>> instead of grammar.cpp.h). My solution's a little nasty, but it  
>> works. It's worth noting that the output filename is configurable  
>> on bison 2.0, e.g. --defines=grammar.cpp.h, but this would break  
>> bison 1.28.
>>
>
> Looks good, I'm about to land the first half of your patch.
>
> For the filename half, though, I'd like something that does not  
> include 2> /dev/null -- I don't want to hide other error messages  
> bison might emit!

bison's errors will still be displayed; this only redirects cat's  
stderr. If you're interesting in cat's output, it'd certainly be  
possible to do something more complex:

[ -e grammar.cpp.h ] && cat grammar.cpp.h || [ -e grammar.hpp ] &&  
cat grammar.hpp > grammar.h

Gorgeous, eh?

- Toby