[webkit-reviews] [PATCH] JavaScriptCore with bison 2.0

Darin Adler darin at apple.com
Tue Jun 7 09:01:37 PDT 2005


On Jun 7, 2005, at 1:52 AM, Toby Peterson wrote:

> Second, bison 2.0 generates a different filename (grammar.hpp  
> instead of grammar.cpp.h). My solution's a little nasty, but it  
> works. It's worth noting that the output filename is configurable  
> on bison 2.0, e.g. --defines=grammar.cpp.h, but this would break  
> bison 1.28.

Looks good, I'm about to land the first half of your patch.

For the filename half, though, I'd like something that does not  
include 2> /dev/null -- I don't want to hide other error messages  
bison might emit!

     -- Darin




More information about the webkit-reviews mailing list