[webkit-reviews] review denied: [Bug 4094] UString for Windows compilation fixes : [Attachment 3055] Recommended Changes

[bugzilla-request-daemon at opendarwin.org]

Darin Adler <darin at apple.com> has denied Justin Haygood
<justin at xiondigital.net>'s request for review:
Bug 4094: UString for Windows compilation fixes
http://bugzilla.opendarwin.org/show_bug.cgi?id=4094

Attachment 3055: Recommended Changes
http://bugzilla.opendarwin.org/attachment.cgi?id=3055&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
#include <xutility> is not the proper way to get std::max; the correct include
is #include <algorithm>.

The #ifdef/#if thing should not have a comment. We don't want a comment
everywhere we're using an #if explaining this general principle.

Same thing with this:

+// #include <stdint.h> replaced with kjsint.h

We don't need a record that this "used to be <stdint.h>".

Finally, I think we could just unconditionally do the ICU stuff here as we did
in that other file, although #if HAVE_ICU is also just fine with me.

Overall looks, good, but setting review- until these last few things are fixed.