[webkit-reviews] review granted: [Bug 4124] change JavaScript property access to avoid double lookup : [Attachment 3077] property change patch - changes get() to getOwnProperty()

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jul 25 15:02:17 PDT 2005


Darin Adler <darin at apple.com> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 4124: change JavaScript property access to avoid double lookup
http://bugzilla.opendarwin.org/show_bug.cgi?id=4124

Attachment 3077: property change patch - changes get() to getOwnProperty()
http://bugzilla.opendarwin.org/attachment.cgi?id=3077&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Maciej convinced me that as a first step, this use of bool is superior to the
in-band signaling of using Value(), given what we plan next.

I re-reviewed the entire patch. r=me



More information about the webkit-reviews mailing list