[webkit-reviews] review denied: [Bug 4011] Editing delegate selection methods not called when using mouse : [Attachment 2975] patch with changelog entries

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jul 18 08:21:04 PDT 2005


Darin Adler <darin at apple.com> has denied Duncan Wilcox <duncan at mclink.it>'s
request for review:
Bug 4011: Editing delegate selection methods not called when using mouse
http://bugzilla.opendarwin.org/show_bug.cgi?id=4011

Attachment 2975: patch with changelog entries
http://bugzilla.opendarwin.org/attachment.cgi?id=2975&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Formatting problem -- if statements say "if(" and should say "if (" instead.

Ideally we should also have a layout test. We added support to the layout test
engine for reporting editing delegate output, and you can create mouse events
using the DOM events support -- with these two things together you should be
able to make a layout test that would work.

Otherwise, looks good.



More information about the webkit-reviews mailing list