[webkit-reviews] review denied: [Bug 3975] JS test suite puts
incorrect limitations on Function.toString() :
[Attachment 2937] Patch
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Mon Jul 18 08:06:09 PDT 2005
Darin Adler <darin at apple.com> has denied Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 3975: JS test suite puts incorrect limitations on Function.toString()
http://bugzilla.opendarwin.org/show_bug.cgi?id=3975
Attachment 2937: Patch
http://bugzilla.opendarwin.org/attachment.cgi?id=2937&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
This needs a comment at least, explaining why it's changed. Later when we merge
our test in with a newer version of the Mozilla tests, we'd like comments to
ease the merging.
An even better alternative would be to figure out a way to make the test
tolerant of the differences in whitespace.
We might even consider making our format more similar to the one from Mozilla
in cases where we like theirs better.
More information about the webkit-reviews
mailing list