[webkit-reviews] review granted: [Bug 3893] -[DOMCSSStyleDeclaration cssText] is not implemented : [Attachment 2921] Address comments

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jul 18 07:59:27 PDT 2005


Darin Adler <darin at apple.com> has granted Anders Carlsson <andersca at mac.com>'s
request for review:
Bug 3893: -[DOMCSSStyleDeclaration cssText] is not implemented
http://bugzilla.opendarwin.org/show_bug.cgi?id=3893

Attachment 2921: Address comments
http://bugzilla.opendarwin.org/attachment.cgi?id=2921&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
It's a little annoying that CSSComputedStyleDeclarationImpl::cssText returns
something with a trailing space.

Is there some better way to share the getPropertyName function than putting
this extern declaration in the .cpp file?

The test looks good to me.

I'm going to mark this review+ even though I have those two minor
questions/comments above.



More information about the webkit-reviews mailing list