[webkit-reviews] review denied: [Bug 3971] JS test suite depends on incorrect JS 1.2 behavior : [Attachment 2935] Patch

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Jul 18 07:54:17 PDT 2005


Darin Adler <darin at apple.com> has denied Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 3971: JS test suite depends on incorrect JS 1.2 behavior
http://bugzilla.opendarwin.org/show_bug.cgi?id=3971

Attachment 2935: Patch
http://bugzilla.opendarwin.org/attachment.cgi?id=2935&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I'd like the change to the tests to at least document what's going on rather
than simply commenting out the code.

When we get new versions of the JS test suite, we may need to merge this change
in, and it would be good to make sure it's "self-documenting".

I must admit I don't entirely understand why removing this code completely is
the best fix, but I think a comment explaining why would probably convince me.



More information about the webkit-reviews mailing list