[webkit-reviews] review denied: [Bug 3829] GW: Several additions to KWQColor : [Attachment 2768] necessary additions to KWQColor

[bugzilla-request-daemon at opendarwin.org]

Maciej Stachowiak <mjs at apple.com> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 3829: GW: Several additions to KWQColor
http://bugzilla.opendarwin.org/show_bug.cgi?id=3829

Attachment 2768: necessary additions to KWQColor
http://bugzilla.opendarwin.org/attachment.cgi?id=2768&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
> +bool parseHexColor(const QString &name, QRgb &rgb) {

No need to make this a member function, suggest just making it a vanilla static
function (maybe inline since it is used exactly once).

Also, don't put the open brace on the line with the function prototype (this
occurs elsehwere in the file as well).

I suggest making the CGColor conversion a free function, and moving hte CIColor
conversion out of this file entirely to avoid requiring an SVG_SUPPORT ifdef.