[webkit-reviews] review denied: [Bug 3826] GW: Add defs to KWQDefs : [Attachment 2765] Adds a few defs to KWQDefs

[bugzilla-request-daemon at opendarwin.org]

Maciej Stachowiak <mjs at apple.com> has denied Eric Seidel
<macdome at opendarwin.org>'s request for review:
Bug 3826: GW: Add defs to KWQDefs
http://bugzilla.opendarwin.org/show_bug.cgi?id=3826

Attachment 2765: Adds a few defs to KWQDefs
http://bugzilla.opendarwin.org/attachment.cgi?id=2765&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
> +typedef __int64_t Q_INT64;
> +typedef __uint64_t Q_UINT64;

Suggest using int64_t and uint_64_t with no underscores instead.

Regarding QMAX/QMIN and KMAX/KMIN, I think it would be better to port the
relevant code to kMax kMin, since that's the direction KHTML went, but failing
that, at least use the typesafe version for QMAX/QMIN.

> +#define qRound(a) lround(a)

Suggest an inline function instead of a macro.