[webkit-reviews] review granted: [Bug 3922] Variable word/letter
spacing and full justification not supported for ATSUI-rendered text :
[Attachment 5227] Support extra spacing features in the ATSUI code path
bugzilla-request-daemon at opendarwin.org
bugzilla-request-daemon at opendarwin.org
Sun Dec 25 08:03:50 PST 2005
Darin Adler <darin at apple.com> has granted opendarwin.org at mitzpettel.com's
request for review:
Bug 3922: Variable word/letter spacing and full justification not supported for
ATSUI-rendered text
http://bugzilla.opendarwin.org/show_bug.cgi?id=3922
Attachment 5227: Support extra spacing features in the ATSUI code path
http://bugzilla.opendarwin.org/attachment.cgi?id=5227&action=edit
------- Additional Comments from Darin Adler <darin at apple.com>
In this:
ceilf((float)style->padding / numSpaces)
there's no need to cast style->padding to a float. If you divide it by a float,
then the result will be floating point without any type cast.
Patch looks good, r=me.
More information about the webkit-reviews
mailing list