[webkit-reviews] review requested: [Bug 6156] Leaks when running SVG tests : [Attachment 5168] Close a couple small leaks from SVG code

bugzilla-request-daemon at opendarwin.org bugzilla-request-daemon at opendarwin.org
Mon Dec 19 22:22:46 PST 2005


Eric Seidel <macdome at opendarwin.org> has asked	for review:
Bug 6156: Leaks when running SVG tests
http://bugzilla.opendarwin.org/show_bug.cgi?id=6156

Attachment 5168: Close a couple small leaks from SVG code
http://bugzilla.opendarwin.org/attachment.cgi?id=5168&action=edit

------- Additional Comments from Eric Seidel <macdome at opendarwin.org>
There are two leaks closed here.  One is specific to DumpRenderTree and is in
the Path->String conversion code.  The second is in the lighting code.	The way
that I closed it is by making the KCanvas lighting element own the light
source.  I'm not sure that's really the best solution long term, but was the
quickest way to victory for now, and is something that can be revisited when we
revisit how filters are handled in KCanvas.



More information about the webkit-reviews mailing list